[PATCH] D22356: [ThinLTO] Perform index-based weak/linkonce resolution in import pass

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: include/llvm/LTO/LTO.h:71
@@ -65,1 +70,3 @@
+        recordNewLinkage,
+    bool PreserveNonPrevailing = false);
 
----------------
pcc wrote:
> Instead of adding this parameter (and adding back isExported), can you simply pass in an isPrevailing that always returns true?
Good idea on changing the IsPrevailing callback to avoid passing IsExported. However we still need the flag to avoid converting to available externally in the non exported case. We need to keep link once as link once e.g. when there is a ref in the same module in case it isn't inlined (and the previous prevailing copy is no longer linked in).


https://reviews.llvm.org/D22356