[PATCH] D22363: [compiler-rt] Add internal wcslen to avoid crashing on windows 64-bits

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 09:07:28 PDT 2016


rnk added inline comments.

================
Comment at: lib/asan/asan_interceptors.cc:588
@@ -587,1 +587,3 @@
   ASAN_INTERCEPTOR_ENTER(ctx, wcslen);
+#if SANITIZER_WINDOWS64
+  // The function is incorrectly hooked on windows 64-bit.
----------------
Eh, I don't think we need an ifdef, we can always use internal_wcslen. Better to be consistent. Nobody uses wcslen on Unix anyway. We added this interceptor for Windows.


https://reviews.llvm.org/D22363





More information about the llvm-commits mailing list