[PATCH] D21849: [AMDGPU] Add metadata for runtime

[Yaxun Liu via llvm-commits]

yaxunl added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:927
@@ +926,3 @@
+    emitRuntimeMDIntValue(OutStreamer, RuntimeMD::KeyArgValueType,
+                          getRuntimeMDValueType(T, BaseTypeName), 2);
+
----------------
yaxunl wrote:
> nhaustov wrote:
> > DataType enum is defined as char, but here 2 bytes are used.
> Data type is now defined as 2 bytes since 1 byte may not be enough for all runtimes.
I will update the header to make it short.


https://reviews.llvm.org/D21849