[PATCH] D22356: [ThinLTO] Perform index-based weak/linkonce resolution in import pass
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 14 08:37:40 PDT 2016
tejohnson added a comment.
As I just noted in https://reviews.llvm.org/D21545, that patch will have the side effect of enabling the linkonce/weak resolution for the distributed backend case. I like the way that patch adds the resolution before invoking the importer, instead of doing it via the FunctionImporter pass as is done here. However, it will expose the bug I am fixing here with the new PreserveNonPrevailing flag. I think I should probably change this patch just to fix that bug and add the new test case, and submit that just after https://reviews.llvm.org/D21545 goes in.
As such, please review the patch ignoring the changes to Transforms/IPO/FunctionImport.cpp, which will go away once https://reviews.llvm.org/D21545 goes in.
https://reviews.llvm.org/D22356
More information about the llvm-commits
mailing list