[PATCH] D22358: [compiler-rt]

[Etienne Bergeron via llvm-commits]

etienneb added a comment.

In https://reviews.llvm.org/D22358#484147, @rnk wrote:

> This passes the 32-bit tests? I would at least expect all the stack frames to be off by one now...


It should pass all tests:

  // Skip the RTL frames by searching for the PC in the stacktrace.
   uptr pc_location = LocatePcInTrace(pc);
   PopStackFrames(pc_location);

This is removing stackframes above the `pc_location`. So, as I get it, this should always be valid.
The drawback, when there is more than 32 stackframe, we may miss the last one.


https://reviews.llvm.org/D22358