[llvm] r275370 - AMDGPU: Fix test not actually testing anything

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 22:23:15 PDT 2016


Author: arsenm
Date: Thu Jul 14 00:23:15 2016
New Revision: 275370

URL: http://llvm.org/viewvc/llvm-project?rev=275370&view=rev
Log:
AMDGPU: Fix test not actually testing anything

It wasn't actually running the pass, and since it is
missing the llvm prefix, the eh intrinsic was not
really an IntrinsicInst.

Also add missing test for lifetime markers.

Added:
    llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll
Modified:
    llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll

Added: llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll?rev=275370&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll (added)
+++ llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll Thu Jul 14 00:23:15 2016
@@ -0,0 +1,24 @@
+; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa -amdgpu-promote-alloca %s | FileCheck -check-prefix=OPT %s
+
+declare void @llvm.lifetime.start(i64, i8* nocapture) #0
+declare void @llvm.lifetime.end(i64, i8* nocapture) #0
+
+; OPT-LABEL: @use_lifetime_promotable_lds(
+; OPT-NOT: alloca i32
+; OPT-NOT: llvm.lifetime
+; OPT: store i32 %tmp3, i32 addrspace(3)*
+define void @use_lifetime_promotable_lds(i32 addrspace(1)* %arg) #2 {
+bb:
+  %tmp = alloca i32, align 4
+  %tmp1 = bitcast i32* %tmp to i8*
+  call void @llvm.lifetime.start(i64 4, i8* %tmp1)
+  %tmp2 = getelementptr inbounds i32, i32 addrspace(1)* %arg, i64 1
+  %tmp3 = load i32, i32 addrspace(1)* %tmp2
+  store i32 %tmp3, i32* %tmp
+  call void @llvm.lifetime.end(i64 4, i8* %tmp1)
+  ret void
+}
+
+attributes #0 = { argmemonly nounwind }
+attributes #1 = { nounwind readnone }
+attributes #2 = { nounwind }

Modified: llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll?rev=275370&r1=275369&r2=275370&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll (original)
+++ llvm/trunk/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll Thu Jul 14 00:23:15 2016
@@ -1,13 +1,13 @@
-; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa < %s | FileCheck %s
+; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa -amdgpu-promote-alloca < %s | FileCheck %s
 
 ; This is just an arbitrary intrinisic that shouldn't ever need to be
 ; handled to ensure it doesn't crash.
 
-declare void @eh.sjlj.functioncontext(i8*) #2
+declare void @llvm.stackrestore(i8*) #2
 
 ; CHECK-LABEL: @try_promote_unhandled_intrinsic(
 ; CHECK: alloca
-; CHECK: call void @eh.sjlj.functioncontext(i8* %tmp1)
+; CHECK: call void @llvm.stackrestore(i8* %tmp1)
 define void @try_promote_unhandled_intrinsic(i32 addrspace(1)* %arg) #2 {
 bb:
   %tmp = alloca i32, align 4
@@ -15,7 +15,7 @@ bb:
   %tmp2 = getelementptr inbounds i32, i32 addrspace(1)* %arg, i64 1
   %tmp3 = load i32, i32 addrspace(1)* %tmp2
   store i32 %tmp3, i32* %tmp
-  call void @eh.sjlj.functioncontext(i8* %tmp1)
+  call void @llvm.stackrestore(i8* %tmp1)
   ret void
 }
 




More information about the llvm-commits mailing list