[PATCH] D22181: Add runtime support for __cpu_model (__builtin_cpu_supports)

[Alina Sbirlea via llvm-commits]

asbirlea marked an inline comment as done.

================
Comment at: lib/builtins/cpu_model.c:203
@@ +202,3 @@
+static bool getX86CpuIDAndInfoEx(unsigned value, unsigned subleaf,
+                                 unsigned *rEAX, unsigned *rEBX, unsigned *rECX,
+                                 unsigned *rEDX) {
----------------
I believe this covers more than isCpuIDSupported. Not sure I should modify/simplify it.

================
Comment at: lib/builtins/cpu_model.c:264
@@ +263,3 @@
+  return false;
+#elif defined(_MSC_FULL_VER) && defined(_XCR_XFEATURE_ENABLED_MASK)
+  unsigned long long Result = _xgetbv(_XCR_XFEATURE_ENABLED_MASK);
----------------
Added a general comment describing the purpose of the method. Did you mean something more specific like "returns XCR0 in rEAX and rEDX"?


http://reviews.llvm.org/D22181