[PATCH] D22308: [pdb] Introduce an MsfBuilder class for laying out PDB files

[Zachary Turner via llvm-commits]

zturner added a subscriber: zturner.
zturner added a comment.

The reason I still kept reset is because without it, subsequent calls to
build will generate invalid layouts, which seemed unintuitive and error
prone. I can fix build() to support this, but it's kind of tricky. Even if
someone can create another builder they shouldn't be able to generate a bad
layout.

About initialize(), In earlier revisions this function could fail, so it
needed to return an Error. But I removed the ability for it to fail.
Although now that I think about it, I should probably validate the block
size.


http://reviews.llvm.org/D22308