[PATCH] D22241: [LV] Avoid unnecessary IV scalar-to-vector-to-scalar conversions

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 13:46:54 PDT 2016


anemet added a comment.

Thanks for the changes, just one more thing.  For absolute paranoia, can you please also add a test with interleaving>1 (no instcombine)?


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2475
@@ +2474,3 @@
+
+          // If GepOperand is a scalarized induction variable, get the scalar
+          // value from ScalarIVMap. Otherwise, extract the appropriate value.
----------------
This sounds a bit confusing.  How about a comment talking about this IV having a scalarized version, like what you say in the next hunk?


http://reviews.llvm.org/D22241





More information about the llvm-commits mailing list