[lld] r275258 - Reverted r275257 "[ELF] - Implement extern "c++" version script tag"

[George Rimar via llvm-commits]

But we do not have any "demangler" yet right ?
I used stupid but workable solution when wrote that patch (I am windows user):

std::string demanglemy(StringRef Name) {
  if (Name == "_Z3foov")
    return "foo()";
  if (Name == "_Z3barv")
    return "bar()";
  if (Name == "_Z3zedv")
    return "zed()";
  return Name;
}

Not sure, but may be we can use that checks for testcase ?
#ifdef windows....


Best regards,
George.
________________________________________
От: Rafael Espíndola <rafael.espindola at gmail.com>
Отправлено: 13 июля 2016 г. 19:27
Кому: George Rimar
Копия: Ed Maste; llvm-commits; Rui Ueyama; David Majnemer
Тема: Re: [lld] r275258 - Reverted r275257 "[ELF] - Implement extern "c++" version script tag"

> What would be a solution for lld ?
> I have concerns about windows users. While we are stick to linux libs
> we can't support them. I think until now and issues with zlib lld was crossplatform linker.
> And we probably want to have a solution for that.

I think the only real solution is to have a c++ demangler in llvm.

For now what we can do is make the cmake check stricter and add a
"REQUIRES: demangler" to the tests.

Cheers,
Rafael