[PATCH] D21785: [RFC]Add unittests to {ARM | AArch64}TargetParser

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 04:07:56 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D21785#479075, @compnerd wrote:

> I think that Id still prefer the AK_ prefix.  However, the only thing that is preventing me from accepting the change is that I haven't really carefully looked through all the cases.  If you have done so, and everything looks okay, fine by me :-).


I don't mind either way (AK, AAK), but if there is anything stopping us from using AK, we should move that discussion later.

If not, I agree we should just keep AK instead. AK means "ArchKind", not "ARMKind", so AArch64 would also be "ArchKind", thus AK.

That would also make this change a lot smaller, and clearer.

thanks,
--renato


http://reviews.llvm.org/D21785





More information about the llvm-commits mailing list