[PATCH] D21801: [ELF] Merge PT_LOAD segments in case they have different attributes and reside in the same memory page

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:215
@@ +214,3 @@
+  typedef typename ELFT::uint uintX_t;
+  uintX_t Alignment = Sec->getAlignment();
+  if (PrevSec && !sectionIsFromParser) {
----------------
btw, may be it is worth to change getAlignment to return unsigned ?
(not relative to this patch, but can help to remove static cast below)

================
Comment at: ELF/LinkerScript.cpp:218
@@ +217,3 @@
+    uintX_t secAttrs = Sec->getFlags() & (SHF_EXECINSTR | SHF_WRITE);
+    uintX_t prevSecAttrs = PrevSec->getFlags() & (SHF_EXECINSTR | SHF_WRITE);
+
----------------
variable names should be uppercase.


http://reviews.llvm.org/D21801