[PATCH] D21995: [ELF] Implement minimal PHDRS parser and section-to-segment assignment

[Hector David via llvm-commits]

Hektve87 added a comment.

In http://reviews.llvm.org/D21995#476580, @evgeny777 wrote:

> I have updated review. All issues fixed, except one (moving createPhdrsUsingSpec to LinkerScript.cpp), because I don't understand very well, how this should be done properly
>  As I wrote earlier, createPhdrsUsingSpec uses a lot of private stuff from Writer:
>
> - Phdrs collection
> - Phdr structure definition
> - Many helper functions: neetdsPtLoad, needsPtInterp, isOutputDynamic, isRelroSection and others
>
>   All of the stuff above is defined in Writer.cpp and is declared private. Writer itself is a template class, so moving part of its definition to header file might not be a good idea. So, please suggest how this should be done properly? Move all required stuff to Writer.h header file (may be to lld::elf namespace)? Something else?


(~~~~)

In http://reviews.llvm.org/D21995#481621, @evgeny777 wrote:

> Review updated


(~~~~)


http://reviews.llvm.org/D21995