[PATCH] D22141: [BFI] Add new LazyBFI analysis pass

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/llvm/Analysis/LazyBlockFrequencyInfo.h:22
@@ +21,3 @@
+//
+// 2. Similarly, getAnalysisUsage should call:
+//
----------------
What is the use model for the new pass manager? Anything worth documenting?

================
Comment at: include/llvm/Analysis/LazyBlockFrequencyInfo.h:91
@@ +90,3 @@
+/// the file comment for the rules of how to use this properly.
+class LazyBlockFrequencyInfoPass : public FunctionPass {
+  LazyBlockFrequencyInfo LBFI;
----------------
Can the wrapper class of BFI be 'inlined' into this class so that we don't need LBFI ?

================
Comment at: lib/Analysis/LazyBlockFrequencyInfo.cpp:38
@@ +37,3 @@
+
+#define DEBUG_TYPE "lazy-block-freq"
+
----------------
Why not also implementing the new PM part of the support?


http://reviews.llvm.org/D22141