[PATCH] D22114: [InstCombine] extend vector select matching for non-splat constants

[Eli Friedman via llvm-commits]

eli.friedman accepted this revision.
eli.friedman added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: test/Transforms/InstCombine/logical-select.ll:374
@@ -378,1 +373,3 @@
+; CHECK-NEXT:    [[TMP1:%.*]] = select <4 x i1> <i1 true, i1 false, i1 false, i1 true>, <4 x i32> %a, <4 x i32> %b
+; CHECK-NEXT:    ret <4 x i32> [[TMP1]]
 ;
----------------
Is a select actually the canonical form for this?  It seems like we should prefer a shufflevector.


http://reviews.llvm.org/D22114