[PATCH] D22269: [SCCP] Replace structs with constants if all the lattice values are constant

[Eli Friedman via llvm-commits]

eli.friedman added a comment.

You probably want to refactor this if you're planning to use it from IPSCCP... but you can do that in the followup, I guess.

In terms of expanding the struct code for vectors, I guess that might work?  It's probably a lot of work for not much benefit, though; it would involve touching every single operation which can work on vectors (including basically every arithmetic operator).


================
Comment at: test/Transforms/SCCP/constant-struct.ll:32
@@ +31,2 @@
+; CHECK-NEXT:  ret { i64, i64, i64 } %c
+; CHECK-NEXT: }
----------------
A little bit more test coverage would be nice... maybe a case which exercise the isOverdefined() path, and a case where the initial value is an argument or something else defined?


http://reviews.llvm.org/D22269