[PATCH] D22250: [PM] Port LoopIdiomRecognize Pass to new PM
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 11:05:46 PDT 2016
davide added a subscriber: davide.
================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:176
@@ +175,3 @@
+ AnalysisManager<Loop> &AM) {
+ // FIXME: Check if loop should be skipped.
+
----------------
Please remove this comment, no other pass has it and better be consistent.
================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:182
@@ +181,3 @@
+
+ auto *AA = FAM.getCachedResult<AAManager>(*F);
+ auto *DT = FAM.getCachedResult<DominatorTreeAnalysis>(*F);
----------------
davidxl wrote:
> Add a comment here about why 'getCachedResult' instead of getResult is used.
+1, you can see Sean thread's for details
http://reviews.llvm.org/D22250
More information about the llvm-commits
mailing list