[PATCH] D21484: AMDGPU/SI: Add support for R_AMDGPU_GOTPCREL

[Matt Arsenault via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with the one fix


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:520
@@ -517,3 +519,3 @@
 
   const Instruction *I = dyn_cast_or_null<Instruction>(Ptr);
   return I && I->getMetadata("amdgpu.uniform");
----------------
You don't need the or_null because of the !Ptr check above


http://reviews.llvm.org/D21484