[PATCH] D22261: [InlineCost] Set minsize inline threshold to 0

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 04:56:07 PDT 2016


jmolloy added a comment.

Hi Chandler,

I've run benchmarking for the test-suite, and this change causes no code change whatsoever.

This is very suspicious, but I've tested and tested again, checked three times - on trivial examples the two compilers I'm testing do have different results (this is on AArch64).

My suspicion for why there is no difference is that trivial functions (getters/setters) are still inlined, as their inline cost is less than the call argument setup cost. This change only really affects larger-than-trivial functions. I'm still suspicious though.

James


Repository:
  rL LLVM

http://reviews.llvm.org/D22261





More information about the llvm-commits mailing list