[PATCH] D21183: Better selection of common base address in constant hoisting

[James Molloy via llvm-commits]

jmolloy added a comment.

This is looking fine to me now, but please wait for Mehdi or someone else to also look it over.


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:261
@@ +260,3 @@
+  int getIntImmCodeSizeCost(unsigned Opcode, unsigned Idx, const APInt &Imm,
+                            Type *Ty) { return 0; }
+
----------------
The formatting here isn't LLVM style. The return sholud be on a new line, then the } on the next line.


http://reviews.llvm.org/D21183