[PATCH] D22116: [ELF] Support for setting the base address
Petr Hosek via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 17:12:40 PDT 2016
phosek added inline comments.
================
Comment at: ELF/Driver.cpp:534
@@ -533,1 +533,3 @@
+ if (auto *Arg = Args.getLastArg(OPT_image_base)) {
+ StringRef S = Arg->getValue();
----------------
ruiu wrote:
> Please move this code to `readConfigs`.
That's a problem; I need `Target` to exists to read `PageSize` and `VAStart`, but `Target` is only created in `link` which is executed after `readConfigs`. Shall I move `Target` initialization out from `link` before `readConfigs`?
http://reviews.llvm.org/D22116
More information about the llvm-commits
mailing list