[PATCH] D22111: [compiler-rt] Refactor the interception code on windows.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 15:38:54 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/interception/interception_win.cc:274
@@ +273,3 @@
+static const int kMaxTrampolineRegion = 1024;
+static TrampolineMemoryRegion TrampolineRegions[kMaxTrampolineRegion];
+
----------------
OK, I believe that.

================
Comment at: lib/interception/tests/interception_win_test.cc:273
@@ +272,3 @@
+    const T &code,
+    TestOverrideFunction Override,
+    FunctionPrefixKind prefix_kind = FunctionPrefixNone) {
----------------
This should be 'override' instead of 'Override', since it's a variable. Also below.


http://reviews.llvm.org/D22111





More information about the llvm-commits mailing list