[PATCH] D22241: [LV] Avoid unnecessary IV scalar-to-vector-to-scalar conversions

[Adam Nemet via llvm-commits]

anemet added a comment.

Hi Matt,

Looks basically good.

A bit more high-level info about the approach would be nice next time.  I think I understand that you are using the new Map in the scalarizeInst.

You're missing tests.

Adam


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:593-596
@@ -592,1 +592,6 @@
 
+  /// A map of scalar values from the original loop to their corresponding
+  /// scalar values in the vectorized loop. Each value in the original loop
+  /// maps to VF * UF values in the new loop.
+  DenseMap<Value *, SmallVector<Value *, 8>> ScalarMap;
+
----------------
Please explain the relation to WidenMap.  It might also be a good idea to move it closer there.


http://reviews.llvm.org/D22241