[PATCH] D22080: [CFLAA] Simplify CFLGraphBuilder by removing InstantiatedRelations and InstantiatedAttrs
Jia Chen via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 14:52:55 PDT 2016
grievejia marked 13 inline comments as done.
================
Comment at: lib/Analysis/CFLGraph.h:42
@@ -56,3 +41,3 @@
struct Edge {
- EdgeType Type;
+ int64_t Offset;
Node Other;
----------------
george.burgess.iv wrote:
> Can you talk about the purpose of `Offset`, please? It looks like it's unused, and only ever has a value of 0. Will this change in the future, or am I missing something?
It is intended for future usage.
But I think you had a point that it's confusing to put an unused field here. Let me remove it for now and add it back in a separate patch.
http://reviews.llvm.org/D22080
More information about the llvm-commits
mailing list