[PATCH] D21952: [compiler-rt] Fix VisualStudio virtual folders layout

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 14:18:54 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm Kuba, let us know if you don't like the new layout.


================
Comment at: test/asan/CMakeLists.txt:106
@@ -105,3 +105,3 @@
   DEPENDS ${ASAN_TEST_DEPS})
-set_target_properties(check-asan PROPERTIES FOLDER "ASan tests")
+set_target_properties(check-asan PROPERTIES FOLDER "Compiler-RT Misc")
 
----------------
etienneb wrote:
> rnk wrote:
> > Not "Compiler-RT Tests"?
> The reason it's like that is to group the "Executables" together.
> So, under "Compiler-RT tests" you have executables.
> The "Misc" is used for the PHONY rules.
> 
> I don't have a strong opinion on where we should put them.
Sounds reasonable, I guess we can keep it in misc.


http://reviews.llvm.org/D21952





More information about the llvm-commits mailing list