[PATCH] D22115: Teach FastISel about thiscall (and, hence, about callee-pop).

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 14:04:14 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D22115#477669, @thakis wrote:

> I looked through a few recent changes to X86FastISel.cpp. Most don't test the early-out branches at all. The ones that fix bugs with commit messages like "bail out to SelectionDAG since it gets this right" usually check that the right code is generated, like the new test I added now does here.


Sounds good

> (ps: It's a bit weird that `retl $65536` silently assembles to `ret 0`)


sad trombone :(


http://reviews.llvm.org/D22115





More information about the llvm-commits mailing list