[PATCH] D22195: AMDGPU: Move SIWholeQuadMode pass to after machine scheduling

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:127
@@ -104,3 +126,3 @@
 
-  void printInfo();
+  void printInfo(MachineFunction &MF);
 
----------------
This should be const or moved to a static helper function. I think it will warn as unused in release builds

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:211
@@ +210,3 @@
+           << ", Self = " << stateString(BI.Needs.Self)
+           << ", Out = " << stateString(BI.Needs.Out) << "\n";
+
----------------
Single quotes around single character

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:216
@@ -183,1 +215,3 @@
+
+      dbgs() << " " << left_justify(stateString(II.Needs), 5) << " " << MI;
     }
----------------
ditto

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:269-270
@@ +268,4 @@
+
+  assert(!II.Needs);
+  assert(Flag == StateWQM || Flag == StateExact);
+
----------------
You can combine these into one assert

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:535
@@ -419,3 +534,3 @@
 
-  if (!(BI.InNeeds & StateWQM))
+  if (!(BI.Needs.In & StateWQM))
     return;
----------------
Can you move the bit test into a helper function in the BI struct, same for everywhere else


http://reviews.llvm.org/D22195