[PATCH] D22086: [ELF] - Add Id field to Version struct.

[Rui Ueyama via llvm-commits]

ruiu added a comment.

LGTM


================
Comment at: ELF/SymbolListFile.cpp:85
@@ -84,1 +84,3 @@
 
+size_t createSymbolVersion(StringRef Version) {
+  // Identifiers start at 2 because 0 and 1 are reserved
----------------
I'd name this `defineSymbolVersion`.

================
Comment at: ELF/SymbolTable.cpp:33
@@ -32,1 +32,3 @@
 
+size_t createSymbolVersion(StringRef Version);
+
----------------
This should be in a .h file.


http://reviews.llvm.org/D22086