[PATCH] D22116: [ELF] Support for setting the base address

[Rui Ueyama via llvm-commits]

ruiu added a comment.

LGTM. I think this option makes sense. It seems to me that `--image-base` feels a bit too Windows-ish name, but I can't think of a better name, so I'm okay with it.

Please make the following changes before commiting.


================
Comment at: ELF/Config.h:104
@@ -103,2 +103,3 @@
   bool Trace;
+  uint64_t VAStart;
   bool Verbose;
----------------
Did you do this?

================
Comment at: ELF/Driver.cpp:534
@@ -533,1 +533,3 @@
 
+  if (auto *Arg = Args.getLastArg(OPT_image_base)) {
+    StringRef S = Arg->getValue();
----------------
Please move this code to `readConfigs`.


http://reviews.llvm.org/D22116