[PATCH] D22210: AMDGPU: Treat texture gather instructions more like other MIMG instructions

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 12:35:19 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3136-3137
@@ -3135,3 +3135,4 @@
 
-  if (TII->isMIMG(Opcode) && !TII->get(Opcode).mayStore())
+  if (TII->isMIMG(Opcode) && TII->get(Opcode).hasPostISelHook() &&
+      !TII->get(Opcode).mayStore())
     adjustWritemask(Node, DAG);
----------------
arsenm wrote:
> Is dmask an operand? can you just see if getNamedOperandIdx says it has the operand?
But yes, a new flag would be better than repurposing this one


http://reviews.llvm.org/D22210





More information about the llvm-commits mailing list