[PATCH] D22210: AMDGPU: Treat texture gather instructions more like other MIMG instructions

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3136
@@ -3135,2 +3135,3 @@
 
-  if (TII->isMIMG(Opcode) && !TII->get(Opcode).mayStore())
+  if (TII->isMIMG(Opcode) && TII->get(Opcode).hasPostISelHook() &&
+      !TII->get(Opcode).mayStore())
----------------
I don't understand why the check for hasPostISelHook is here. It shouldn't be a relevant property to check here

================
Comment at: test/CodeGen/AMDGPU/llvm.SI.gather4.ll:468-470
@@ +467,5 @@
+; This crashed at some point due to a bug in FixSGPRCopies. Derived from the
+; report in https://bugs.freedesktop.org/show_bug.cgi?id=96877
+;
+define amdgpu_ps float @gather4_sgpr_bug() {
+main_body:
----------------
Needs some check lines


http://reviews.llvm.org/D22210