[PATCH] D22214: Convert a signed remainder instruction to unsigned remainder
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 06:54:42 PDT 2016
jmolloy added inline comments.
================
Comment at: lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:344
@@ -347,3 +343,3 @@
for (Value *O : SDI->operands()) {
LazyValueInfo::Tristate Result =
LVI->getPredicateAt(ICmpInst::ICMP_SGE, O, Zero, SDI);
----------------
You can simplify this by using "auto"
================
Comment at: lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:353
@@ +352,3 @@
+static bool processSRem(BinaryOperator *SDI, LazyValueInfo *LVI) {
+ if (SDI->getType()->isVectorTy())
+ return false;
----------------
All of these checks can be combined into one if with ||.
http://reviews.llvm.org/D22214
More information about the llvm-commits
mailing list