[PATCH] D9401: llvm.noalias - The AA implementaton

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Analysis/ScopedNoAliasAA.cpp:282
@@ +281,3 @@
+  auto NAI =
+    std::find_if(NoAliasCalls.begin(), NoAliasCalls.end(),
+                 [&](Instruction *A) {
----------------
majnemer wrote:
> `llvm::find_if` ?
Nice! I didn't know we had that :-)

================
Comment at: lib/Analysis/ScopedNoAliasAA.cpp:304-307
@@ +303,6 @@
+  SmallVector<const Value *, 8> Children;
+  if (const SelectInst *SI = dyn_cast<SelectInst>(P)) {
+    Children.push_back(SI->getTrueValue());
+    Children.push_back(SI->getFalseValue());
+  } else if (const PHINode *PN = dyn_cast<PHINode>(P)) {
+    for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
----------------
majnemer wrote:
> `const auto *`
Sure, and I'll make all of the updates you've suggested below. Thanks!



http://reviews.llvm.org/D9401