[PATCH] D22172: Added REQUIRES to TestingGuide documentation

[Paul Robinson via llvm-commits]

probinson added a comment.

I think you can also use triple components in REQUIRES, which makes me wonder about 'x86_64-linux'. Is that something lit supports separately from the triple check?


================
Comment at: docs/TestingGuide.rst:399
@@ +398,3 @@
+    ; This test will be only enabled in the build with asserts
+    ; REQUIRES asserts
+
----------------
I think you need a colon after REQUIRES.

================
Comment at: docs/TestingGuide.rst:401
@@ +400,3 @@
+
+You can separate requirements by a coma.
+If test depends on one of many requirements, use ``REQUIRES-ANY``.
----------------
coma -> comma

================
Comment at: docs/TestingGuide.rst:402
@@ +401,3 @@
+You can separate requirements by a coma.
+If test depends on one of many requirements, use ``REQUIRES-ANY``.
+
----------------
I would rather see the two forms contrasted more directly, maybe like this:

REQUIRES means all listed requirements must be satisfied; REQUIRES-ANY means at least one must be satisfied.

================
Comment at: docs/TestingGuide.rst:429
@@ -390,1 +428,3 @@
+- global-isel
+- xar
 
----------------
Please sort the list alphabetically.  If you prefer to keep the "not" versions with the positive versions, that's fine.

Just curious, what is 'xar'?


http://reviews.llvm.org/D22172