[PATCH] D21484: AMDGPU/SI: Add support for R_AMDGPU_GOTPCREL

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:30
@@ -29,2 +29,3 @@
 #include "llvm/ADT/StringSwitch.h"
+#include "llvm/CodeGen/Analysis.h"
 #include "llvm/CodeGen/CallingConvLower.h"
----------------
I don't think I see anything that uses anything new from this

================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.h:19
@@ -18,2 +18,3 @@
 #include "SIRegisterInfo.h"
+#include "llvm/CodeGen/PseudoSourceValue.h"
 #include <array>
----------------
Belongs with pseudosourcevalue patch

================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.h:399
@@ -397,2 +398,3 @@
   unsigned getMaximumWorkGroupSize(const MachineFunction &MF) const;
+
 };
----------------
Extra line


http://reviews.llvm.org/D21484