[PATCH] D22156: NVPTX: Avoid implicit iterator conversions, NFC
Duncan P. N. Exon Smith via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 8 14:18:44 PDT 2016
Thanks for the review! Committed in r274931. (Answers to your questions below, inline.)
> On 2016-Jul-08, at 13:42, Justin Lebar <jlebar at google.com> wrote:
>
> jlebar added a subscriber: jlebar.
> jlebar added a comment.
>
>> in the MSP430 backend
>
>
> Wrong commit message?
>
>> from MachineInstrBundleInstr
>
>
> MachineInstrBundleIterator?
Fixed both. Thanks for noticing!
>
> Otherwise looks good to me. This is a simplification, so I like it on face, but do you also expect this change (when made everywhere in llvm) to have performance implications?
I expect no performance implications.
>
>
> http://reviews.llvm.org/D22156
>
>
>
More information about the llvm-commits
mailing list