[PATCH] D22152: Hexagon: Avoid implicit iterator conversions, NFC

[Duncan P. N. Exon Smith via llvm-commits]

dexonsmith created this revision.
dexonsmith added a subscriber: llvm-commits.

Avoid implicit iterator conversions from MachineInstrBundleInstr to
MachineInstr* in the Hexagon backend, mostly by preferring MachineInstr&
over MachineInstr* and switching to range-based for loops.

There's a long tail of API cleanup here, but I'm planning to leave the
rest to the Hexagon maintainers.  HexagonInstrInfo defines many of its
own predicates, and most of them still take MachineInstr*.  Some of
those actually check for nullptr, so I didn't feel comfortable changing
them to MachineInstr& en masse.


http://reviews.llvm.org/D22152

Files:
  lib/Target/Hexagon/BitTracker.cpp
  lib/Target/Hexagon/BitTracker.h
  lib/Target/Hexagon/HexagonBitSimplify.cpp
  lib/Target/Hexagon/HexagonBitTracker.cpp
  lib/Target/Hexagon/HexagonBitTracker.h
  lib/Target/Hexagon/HexagonCFGOptimizer.cpp
  lib/Target/Hexagon/HexagonCopyToCombine.cpp
  lib/Target/Hexagon/HexagonExpandCondsets.cpp
  lib/Target/Hexagon/HexagonFixupHwLoops.cpp
  lib/Target/Hexagon/HexagonGenMux.cpp
  lib/Target/Hexagon/HexagonGenPredicate.cpp
  lib/Target/Hexagon/HexagonNewValueJump.cpp
  lib/Target/Hexagon/HexagonPeephole.cpp
  lib/Target/Hexagon/HexagonSplitConst32AndConst64.cpp
  lib/Target/Hexagon/HexagonVLIWPacketizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22152.63279.patch
Type: text/x-patch
Size: 80158 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160708/b524bce6/attachment.bin>