[PATCH] D18226: Codegen: Tail-duplicate during placement.

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 12:02:48 PDT 2016


davidxl added inline comments.

================
Comment at: lib/CodeGen/BranchFolding.cpp:656
@@ +655,3 @@
+  // duplicated.
+  if (!AfterPlacement)
+    if (SuccBB && MBB1 != PredBB && MBB2 != PredBB &&
----------------
Depending on the threshold difference can be fragile. 

How about changing AfterPlacement into a callback/lambda function using function_ref<..>. It tells tailMerge if a block should be skipped.


http://reviews.llvm.org/D18226





More information about the llvm-commits mailing list