[PATCH] D21405: [PGO] IRPGO pre-cleanup pass changes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 11:09:14 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:228
@@ +227,3 @@
+    MPM.add(createSROAPass());
+    MPM.add(createEarlyCSEPass());             // Catch trivial redundancies
+    MPM.add(createCFGSimplificationPass());    // Merge & remove BBs
----------------
mehdi_amini wrote:
> Uh? Since we have Os/Oz as function attribute, it seems strange to me to have this hard-coded on a global level.
Also is it duplicating `llvm::computeThresholdFromOptLevels` ?


http://reviews.llvm.org/D21405





More information about the llvm-commits mailing list