[PATCH] D22086: [ELF] - Add Id field to Version struct.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM


================
Comment at: ELF/Config.h:45
@@ -44,2 +44,3 @@
   size_t NameOff; // Offset in string table.
+  size_t Id;
 };
----------------
I'd move this after `Name` so that `Name` and `Id` (arguments passed by user) are next to each other.

================
Comment at: ELF/SymbolListFile.cpp:88
@@ +87,3 @@
+  // Identifiers start at 2 because 0 and 1 are reserved
+  // by VER_NDX_LOCAL and VER_NDX_GLOBAL constants.
+  Config->SymbolVersions.push_back(
----------------
s/by/for/


http://reviews.llvm.org/D22086