[PATCH] D21982: WIP: Implement a per-thread inmemory log

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/xray/xray_inmemory_log.cc:72
@@ +71,3 @@
+        continue; // Try again.
+      fprintf(stderr, "Failed to write; errno = %d", errno);
+      return;
----------------
I does not matter much for this patch, but for my own curiosity, do you have a pointer to the doc that mentions the zero returned case?

================
Comment at: lib/xray/xray_inmemory_log.cc:122
@@ +121,3 @@
+    // other way.
+    printf("XRay: Log file in '%s'\n", TmpFilename);
+    return Fd;
----------------
stderr maybe?


http://reviews.llvm.org/D21982