[PATCH] D22025: AMDGPU/SI: Do not insert EndCf in an unreachable block

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 08:57:18 PDT 2016


arsenm added a comment.

In http://reviews.llvm.org/D22025#474703, @arsenm wrote:

> I don't agree that it doesn't make sense to put the end.cf into an unreachable block. If it ordinarily would go into a block in that place, it makes sense. This needs IR checklines for the intrinsic insertion points


This needs tome tests where there are instructions before the unreachable. If other instruction like an abort were there, the end cf still needs to be inserted


http://reviews.llvm.org/D22025





More information about the llvm-commits mailing list