[PATCH] D22079: Refactor Archive-child iteration.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: lib/Object/Archive.cpp:670
@@ -667,3 +669,3 @@
 
-Archive::child_iterator Archive::findSym(StringRef name) const {
+Archive::child_iterator Archive::findSym(Error &Err, StringRef name) const {
   Archive::symbol_iterator bs = symbol_begin();
----------------
Can you change this to return Optional<Archive::Child>?

The iterator was only use a convenient form of Optional, but now that it requires an Error it is not as convenient for this function.



Repository:
  rL LLVM

http://reviews.llvm.org/D22079