[PATCH] D22139: Do not expand SDIV when compiling for minimum code size

[Sjoerd Meijer via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL274855: Do not expand SDIV when compiling for minimum code size (authored by SjoerdMeijer).

Changed prior to commit:
  http://reviews.llvm.org/D22139?vs=63231&id=63233#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D22139

Files:
  llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll

Index: llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll
===================================================================
--- llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll
+++ llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll
@@ -1,16 +1,36 @@
-; When optimising for minimum size, we don't want to expand a udiv to a mul
-; and a shift sequence. As a result, the urem instruction will not be
+; When optimising for minimum size, we don't want to expand a div to a mul
+; and a shift sequence. As a result, the urem instruction e.g. will not be
 ; expanded to a sequence of umull, lsrs, muls and sub instructions, but
 ; just a call to __aeabi_uidivmod.
 ;
 ; RUN: llc -mtriple=armv7a-eabi -mattr=-neon -verify-machineinstrs %s -o - | FileCheck %s
 
 target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
 target triple = "thumbv7m-arm-none-eabi"
 
-define i32 @foo() local_unnamed_addr #0 {
+define i32 @foo1() local_unnamed_addr #0 {
 entry:
-; CHECK-LABEL: foo:
+; CHECK-LABEL: foo1:
+; CHECK:__aeabi_idiv
+; CHECK-NOT: smmul
+  %call = tail call i32 bitcast (i32 (...)* @GetValue to i32 ()*)()
+  %div = sdiv i32 %call, 1000000
+  ret i32 %div
+}
+
+define i32 @foo2() local_unnamed_addr #0 {
+entry:
+; CHECK-LABEL: foo2:
+; CHECK: __aeabi_uidiv
+; CHECK-NOT: umull
+  %call = tail call i32 bitcast (i32 (...)* @GetValue to i32 ()*)()
+  %div = udiv i32 %call, 1000000
+  ret i32 %div
+}
+
+define i32 @foo3() local_unnamed_addr #0 {
+entry:
+; CHECK-LABEL: foo3:
 ; CHECK: __aeabi_uidivmod
 ; CHECK-NOT: umull
   %call = tail call i32 bitcast (i32 (...)* @GetValue to i32 ()*)()
Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -14475,6 +14475,11 @@
 /// by a magic number.
 /// Ref: "Hacker's Delight" or "The PowerPC Compiler Writer's Guide".
 SDValue DAGCombiner::BuildSDIV(SDNode *N) {
+  // when optimising for minimum size, we don't want to expand a div to a mul
+  // and a shift.
+  if (DAG.getMachineFunction().getFunction()->optForMinSize())
+    return SDValue();
+
   ConstantSDNode *C = isConstOrConstSplat(N->getOperand(1));
   if (!C)
     return SDValue();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22139.63233.patch
Type: text/x-patch
Size: 2279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160708/4dd1f999/attachment.bin>