[PATCH] D21038: AMDGPU/AsmParser: Add support for parsing symbol operands

Artem Tamazov via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 06:52:23 PDT 2016


artem.tamazov added a comment.

It seems that labels in branches were not anticipated in this patch.
The quickfix is under review, http://reviews.llvm.org/D22133.

Shall we try another approach for this feature; this one looks like a hack?..
Another problem (different story, but newertheless):

  .set foo 40
  s_branch foo

Branch offset will be something like (40-PC) but correct one should be  +40, I guess. Shall we differentiate between labels and other kinds of symbols?


Repository:
  rL LLVM

http://reviews.llvm.org/D21038





More information about the llvm-commits mailing list