[lld] r274803 - -Bsymbolic should not make symbols more preemptable.

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Thu Jul  7 17:50:54 2016
New Revision: 274803

URL: http://llvm.org/viewvc/llvm-project?rev=274803&view=rev
Log:
-Bsymbolic should not make symbols more preemptable.

But it was doing that for protected undefined symbols.

Modified:
    lld/trunk/ELF/Symbols.cpp
    lld/trunk/test/ELF/bsymbolic.s

Modified: lld/trunk/ELF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=274803&r1=274802&r2=274803&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.cpp (original)
+++ lld/trunk/ELF/Symbols.cpp Thu Jul  7 17:50:54 2016
@@ -129,11 +129,14 @@ bool SymbolBody::isPreemptible() const {
   if (!symbol()->includeInDynsym())
     return false;
 
-  // Normally only default visibility symbols can be preempted, but -Bsymbolic
-  // means that not even they can be preempted.
+  // Only default visibility symbols can be preempted.
+  if (symbol()->Visibility != STV_DEFAULT)
+    return false;
+
+  // -Bsymbolic means that definitions are not preempted.
   if (Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc()))
     return !isDefined();
-  return symbol()->Visibility == STV_DEFAULT;
+  return true;
 }
 
 template <class ELFT> InputFile *SymbolBody::getSourceFile() {

Modified: lld/trunk/test/ELF/bsymbolic.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/bsymbolic.s?rev=274803&r1=274802&r2=274803&view=diff
==============================================================================
--- lld/trunk/test/ELF/bsymbolic.s (original)
+++ lld/trunk/test/ELF/bsymbolic.s Thu Jul  7 17:50:54 2016
@@ -28,3 +28,7 @@ nop
 do: 
 callq foo at PLT
 callq bar at PLT
+
+.weak zed
+.protected zed
+.quad zed