[PATCH] D22001: [DSE] Remove dead stores in end blocks containing fence

[Mailing List "llvm-commits" via llvm-commits]

llvm-commits added a comment.

> anna marked an inline comment as done.

>  anna added a comment.

> 

> In http://reviews.llvm.org/D22001#474590, @dexonsmith wrote:

> 

> > I don't see a patch on the list.  Is this a problem with how you created the Phab review?

> 

> 

> Sent patch separately to @dexonsmith. Response on patch:

>  `isa` works on references as well as pointers, so this can just be

> 

>   if (isa<FenceInst>(*BBI))

>    

> 

> Agree with Duncan, but the llvm ref states that this implicit conversion comes at a cost, and at some point in time, may be reverted to mean what standard iterators are. So, I'll leave it as-is to avoid any fix-ups required in future.


What implicit conversion??

> "Unfortunately, these implicit conversions come at a cost; they prevent these iterators from conforming to standard iterator conventions, and thus from being usable with standard algorithms and containers. Because of this, these implicit conversions may be removed some day, and operator* changed to return a pointer instead of a reference."

>  http://llvm.org/docs/ProgrammersManual.html#basic-inspection-and-traversal-routines




_______________________________________________

llvm-commits mailing list
llvm-commits at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


http://reviews.llvm.org/D22001