[PATCH] D22074: GlobalISel: legalization policy class

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 11:38:22 PDT 2016


arsenm added inline comments.

================
Comment at: include/llvm/CodeGen/GlobalISel/MachineLegalizer.h:67
@@ +66,3 @@
+    Custom,
+  };
+
----------------
There's one value left in uint8_t, can we make it be unsupported? We custom lower a variety of operations now just to emit an error saying they don't work

================
Comment at: lib/CodeGen/GlobalISel/MachineLegalizer.cpp:80-81
@@ +79,4 @@
+  if (MaxLegalElts > NumElts) {
+    return findLegalAction(Opcode, Ty, MoreElements);
+  } else if (MaxLegalElts == 0) {
+    // Scalarize if there's no legal vector type, which is just a special case
----------------
No else after return


Repository:
  rL LLVM

http://reviews.llvm.org/D22074





More information about the llvm-commits mailing list