[PATCH] Use path relative to $llvm in build docs

Manish Goregaokar via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 10:06:12 PDT 2016


If build is $llvm/../build, and if you are currently in build, cmake
.. will not do the right thing (since .. is $llvm/..); you need `cmake
$llvm`. I messed up the patch however.

New patch:

diff --git a/www/build.html b/www/build.html
index 7f8a5c9..147f997 100755
--- a/www/build.html
+++ b/www/build.html
@@ -287,14 +287,14 @@
               ninja on your system. To build using ninja:
             </p>
             <code>
-              > cmake .. -G Ninja
+              > cmake $llvm -G Ninja
               <br />> ninja lldb
               <br />> ninja check-lldb
             </code>
             <h3>Using CMake + Unix Makefiles</h3>
             <p>If you do not have Ninja, you can still use CMake to
generate Unix Makefiles that build LLDB:</p>
             <code>
-              > cmake ..
+              > cmake $llvm
               <br />> make
               <br />> make check-lldb
             </code>

-Manish


On Thu, Jul 7, 2016 at 4:54 AM, Vedant Kumar <vsk at apple.com> wrote:
> Hi Manish,
>
> It looks like the docs suggest:
>
>   $ cd $llvm/..
>   $ mkdir build
>   $ cd build
>
> So, "cmake .." should do the right thing. Have you had issues with this?
>
> vedant
>
>
>> On Jul 3, 2016, at 11:48 AM, Manish Goregaokar via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> From https://llvm.org/bugs/show_bug.cgi?id=28092, didn't realize it
>> needed to be sent to the mailing list
>>
>> ---
>> www/build.html | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/www/build.html b/www/build.html
>> index 7f8a5c9..147f997 100755
>> --- a/www/build.html
>> +++ b/www/build.html
>> @@ -287,14 +287,14 @@
>>               ninja on your system. To build using ninja:
>>             </p>
>>             <code>
>> -              > cmake .. -G Ninja
>> +              > cmake $llvm/... -G Ninja
>>               <br />> ninja lldb
>>               <br />> ninja check-lldb
>>             </code>
>>             <h3>Using CMake + Unix Makefiles</h3>
>>             <p>If you do not have Ninja, you can still use CMake to
>> generate Unix Makefiles that build LLDB:</p>
>>             <code>
>> -              > cmake ..
>> +              > cmake $llvm/..
>>               <br />> make
>>               <br />> make check-lldb
>>             </code>
>> --
>> 2.8.3
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list