[PATCH] D22064: [X86] Make some cast costs more precise

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:540
@@ -539,3 +539,3 @@
     { ISD::UINT_TO_FP,  MVT::v8f32,  MVT::v8i64,  1 },    
     { ISD::UINT_TO_FP,  MVT::v8f64,  MVT::v8i64,  1 },
 
----------------
mkuper wrote:
> RKSimon wrote:
> > Depending on how thorough we need to be shouldn't there be AVX512DQ+AVX512VL UINT_TO_FP cases for 128/256 bit vectors?
> Probably.
> I'd rather leave that to the Intel folks, they can probably get more precise numbers for SKX.
In this case, even if you have only DQ without VL, the conversion is in ZMM instead of YMM, but the cost is the same.

================
Comment at: test/Analysis/CostModel/X86/sitofp.ll:273
@@ -272,3 +272,3 @@
   ; AVX512F-LABEL: sitofpv4i64v4double
-  ; AVX512F: cost of 10 {{.*}} sitofp
+  ; AVX512F: cost of 13 {{.*}} sitofp
   %1 = sitofp <4 x i64> %a to <4 x double>
----------------
We should have a nicer cost for DQ here, because it handles all 64 bit integers, right?


http://reviews.llvm.org/D22064